Feat/dockerfile hadolint scan ent backport#380
Closed
deepak-devtron wants to merge 6 commits into
Closed
Conversation
- Add BuildxBuilderPodWaitDurationSecs to CommonWorkflowRequest (JSON field) - Add BuildxK8sClientFactory type+field for testability; default wraps newBuildxK8sClient - Extract waitForBuilderPods as a package-level helper (testable) - Add initial pod liveness wait in setupBuildxBuilder after RegisterBuilderPods to eliminate false-positive BuilderPodDeletedError from pod startup latency - executeDockerReBuild: use factory for k8s client, buffered done channel (size 1) to prevent goroutine leak, context.WithTimeout instead of time.After - Fix pre-existing GitManager_test.go broken CloneAndCheckout call signature - Tests (Groups A-D, F-G): 15 unit tests covering duration computation, executeDockerReBuild error paths, waitForBuilderPods, JSON compat
deepak-devtron
requested review from
prakarsh-dt,
vikramdevtron and
vivek-devtron
as code owners
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP }404).\n |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.